Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std lib #2

Closed
wants to merge 183 commits into from
Closed

use std lib #2

wants to merge 183 commits into from

Conversation

suzaku
Copy link
Owner

@suzaku suzaku commented Aug 15, 2023

suzaku and others added 30 commits June 29, 2023 02:36
Signed-off-by: cleverhu <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
…oproj#14262)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@ecf9528...16c0bc4)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#14263)

Bumps library/busybox from `6e49438` to `2376a0c`.

---
updated-dependencies:
- dependency-name: library/busybox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0.4 (argoproj#14264)

Bumps [github.com/alicebob/miniredis/v2](https://github.com/alicebob/miniredis) from 2.30.3 to 2.30.4.
- [Release notes](https://github.com/alicebob/miniredis/releases)
- [Changelog](https://github.com/alicebob/miniredis/blob/master/CHANGELOG.md)
- [Commits](alicebob/miniredis@v2.30.3...v2.30.4)

---
updated-dependencies:
- dependency-name: github.com/alicebob/miniredis/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#14265)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.290 to 1.44.292.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.290...v1.44.292)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.7.2 to 3.8.3.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-node@v3.7.2...v3.8.3)

---
updated-dependencies:
- dependency-name: codecov
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#14278)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.292 to 1.44.293.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.292...v1.44.293)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: crenshaw-dev <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
…goproj#14268)

* Added rel attribute to link

Signed-off-by: aakankshabhende <[email protected]>

* Fixed lint error

Signed-off-by: aakankshabhende <[email protected]>

---------

Signed-off-by: aakankshabhende <[email protected]>
* docs: explicit that ArgoCD hooks replace the Helm ones

After digging a bit in the code, I've found this comment that confirms
that if we define some ArgoCD hooks the Helm ones are ignored.
https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46

Signed-off-by: Benoît Sauvère <[email protected]>

* docs: add Back Market in the user list

Signed-off-by: Benoît Sauvère <[email protected]>

* Update docs/user-guide/helm.md

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Benoît Sauvère <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
…oj#14279)

* fix: change to the correct property for dex server

Signed-off-by: bjarneo <[email protected]>

* Update argocd-cmd-params-cm.yaml

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: bjarneo <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Add `ssh_keyscan` example usage

Signed-off-by: Daniel Perevalov <[email protected]>
…14275)

* chore: add more logging for failures to get label metadata

Signed-off-by: Michael Crenshaw <[email protected]>

* context

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: jannfis <[email protected]>
Co-authored-by: jannfis <[email protected]>
…#14310)

* feat: update dexidp image tag from v2.36.0 -> v2.37.0

Signed-off-by: Venkata Mutyala <[email protected]>

* chore: adding GlueOps to USERS.md

Signed-off-by: Venkata Mutyala <[email protected]>

---------

Signed-off-by: Venkata Mutyala <[email protected]>
…goproj#13479)

* feat: respecting rbac for resource exclusions/inclusions proposal (argoproj#13479)

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
… (argoproj#14307)

* change disallowed application destinations message

Signed-off-by: michaelkot97 <[email protected]>

* Changed e2e tests

Signed-off-by: michaelkot97 <[email protected]>

---------

Signed-off-by: michaelkot97 <[email protected]>
…argoproj#14313)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.293 to 1.44.294.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.293...v1.44.294)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#14327)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.294 to 1.44.295.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.294...v1.44.295)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…i-build.yaml (argoproj#13729)

* fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml

Signed-off-by: Denis Dupeyron <[email protected]>

* fix go formatting issues using gofmt

Signed-off-by: Denis Dupeyron <[email protected]>

* chore: simplify go code using gofmt

Signed-off-by: Denis Dupeyron <[email protected]>

---------

Signed-off-by: Denis Dupeyron <[email protected]>
Signed-off-by: Julien Bouquillon <[email protected]>
)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@64ed1c7...e33196f)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
vipin-m-s and others added 27 commits August 7, 2023 20:21
* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* Update applicationset/controllers/applicationset_controller.go

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
…shared projects from subgroups projects (argoproj#14831)

* added option to disable gitlab to fetch shared project from a subgroup

Signed-off-by: Prune <[email protected]>

* Correct gitlab SCM provider mock test

Signed-off-by: Prune <[email protected]>

* updated test to validate shared-groups

Signed-off-by: Prune <[email protected]>

* reworked shared project tests

Signed-off-by: Prune <[email protected]>

* added subgroups only test

Signed-off-by: Prune <[email protected]>

---------

Signed-off-by: Prune <[email protected]>
…tential cleanup (argoproj#9180) (argoproj#14955)

* fix: send sigterm to cmp commands before sigkill to allow for potential cleanup

Signed-off-by: Ashin Sabu <[email protected]>

* fix: unit test for runCommand in cmpserver to test cleanup modified

Signed-off-by: Ashin Sabu <[email protected]>

* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix

Signed-off-by: Ashin Sabu <[email protected]>

---------

Signed-off-by: Ashin Sabu <[email protected]>
* Create bounty proposal

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

---------

Signed-off-by: Dan Garfield <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@fac708d...93397be)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Block <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
* feat: Add Support for AzureDevops Webhooks

Signed-off-by: Alexander Matyushentsev <[email protected]>

* document azure devops webhook configuration

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
…4979)

* Update default and max count for maxCookieNumber

Signed-off-by: zvlb <[email protected]>
Upgrade from 1.8.6 to 1.8.7 due to high security issue

Was solved in dependency with coder/websocket#291

Signed-off-by: jmeridth <[email protected]>
…rgoproj#14996)

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@336e299...3fa32b8)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: give context to errors

Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Apply suggestions from code review

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
* chore: give context to error logs in reposerver

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors in applicationset

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors(tweaks in error messages)

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors(fix unit test)

Signed-off-by: Ashin Sabu <[email protected]>

---------

Signed-off-by: Ashin Sabu <[email protected]>
… number of executors (argoproj#11877)

Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.

Signed-off-by: Philipp Dallig <[email protected]>
)

* fix: loosen source not permitted helm errors

With argoproj#12255, we check if a source is first permitted before running
`helm template`. This works a bit too well, since this may break
previously working manifests. If an `AppProject` has a set of
`sourceRepos` which are more restrictive than `*`, and it also has Helm
public dependencies (repos with credentials would not work with 2.7x
due to the fact they get filtered out before ending up on the repo
server). Whereas before this would work, this currently fails on
`HEAD` but not in `2.7x`.

What we instead do here is that we only run this check if the chart
failed to download - if it does then we run a check to see if the repo
is in the allowed repos list. If the repo is not in the allowed repos
list, we return the same error as in argoproj#12555, otherwise we bubble up the
error.

Should fix argoproj#13833.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: check for 401 unauthorized in error

The regex check works fine for OCI artifacts, but the flow is slightly
different for standard Helm charts (specifically when running
`helm repo add`). To get around that, we also check the error for
`401 Unauthorized`.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: loosen string check

Signed-off-by: Blake Pettersson <[email protected]>

* Revert "chore: revert argoproj#12255 (argoproj#14858)"

This reverts commit c8ae5bc.

Signed-off-by: Blake Pettersson <[email protected]>

* wip

Signed-off-by: Blake Pettersson <[email protected]>

* wip

Signed-off-by: Blake Pettersson <[email protected]>

* chore: reword test to reduce confusion

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
* feat: support apply out of sync flag only

Signed-off-by: pashakostohrys <[email protected]>

* update engine version

Signed-off-by: pashakostohrys <[email protected]>

* update gitops engine version

Signed-off-by: pashakostohrys <[email protected]>

* add cli option

Signed-off-by: pashakostohrys <[email protected]>

* feat: verify apply out of sync flag

Signed-off-by: pashakostohrys <[email protected]>

* redundant comment

Signed-off-by: pashakostohrys <[email protected]>

* improve test logic

Signed-off-by: pashakostohrys <[email protected]>

* change command description and do codegen

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
…14888)

- the DCO and FAQ sentences are not filled out during PRs and are purely notational
  - comment them out with HTML comments, as is common practice
    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1
      - copied this practice from other repos I maintain and from other repos before that
- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise

Signed-off-by: Anton Gilgur <[email protected]>
@suzaku suzaku closed this Aug 22, 2023
@suzaku suzaku deleted the use-std-lib branch August 22, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment